Add chunks_done field to submissions_failed#108
Merged
OpsBotPrime merged 3 commits intoMay 26, 2026
Conversation
jerbaroo
force-pushed
the
jerbaroo-104-add-chunks_done-to-submissions_failed
branch
from
6c8ae84 to
5968e74
Compare
Qqwy
approved these changes
May 21, 2026
Contributor
Qqwy
left a comment
Qqwy
left a comment
There was a problem hiding this comment.
Thank you very much!
This is wonderfully straightforward PR, implementing exactly the desired change and nothing else. Well done 👍!
We could release a new version in a few days time that turns the nullable field into a required field, as done submissions are removed after a while (which is configurable but usually is a few days IIRC).
Contributor
Author
Yep sounds good, will follow-up with that in a few days :) Edit: tracking in #110 |
jerbaroo
force-pushed
the
jerbaroo-104-add-chunks_done-to-submissions_failed
branch
from
5968e74 to
593049b
Compare
jerbaroo
force-pushed
the
jerbaroo-104-add-chunks_done-to-submissions_failed
branch
from
593049b to
02c62f6
Compare
Contributor
Author
|
@OpsBotPrime merge and tag |
Approved-by: jerbaroo Priority: Normal Auto-deploy: false
Contributor
|
Rebased as 40634ba, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104
This PR adds a NULLABLE (for backwards-compatibility) field
chunks_doneto the tablesubmissions_failed. There is also a corresponding field added to the twoSubmissionFailedRust types (internal and exported by PyO3).Tests: integration test which consumes two chunks and failed on the 3rd chunk. The
SubmissionFailedErrorincludes aSubmissionFailedwith achunks_donevalue of 2.